Update AppleSequencer to work in Xcode15.3+ #2912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MIDISampler has a different enableMIDI method from the one in MIDICallbackInstrument. This makes them more similar, and fixes the issue with MIDISampler not playing from AppleSequencer in Xcode 15.3.
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
aure
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MIDISampler has a different enableMIDI method from the one in MIDICallbackInstrument. This PR makes them more similar, and fixes the issue with MIDISampler not being triggered from AppleSequencer in Xcode 15.3+. I tested this in the latest version of the Cookbook and it works with the MusicToy recipe. Mentioned here: #2901