Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance lqr steering control docs #1015

Merged
merged 5 commits into from May 25, 2024
Merged

Enhance lqr steering control docs #1015

merged 5 commits into from May 25, 2024

Conversation

AtsushiSakai
Copy link
Owner

Reference issue

Fix #992

What does this implement/fix?

Additional information

CheckList

  • Did you add an unittest for your new example or defect fix?
  • Did you add documents for your new example?
  • All CIs are green? (You can check it after submitting)

@AtsushiSakai AtsushiSakai mentioned this pull request May 12, 2024
Closed
@AtsushiSakai
Copy link
Owner Author

@lijieamd @Gopigunaganti @xiao-ge4 Is it possible to review this PR? You can check the updated doc here:

image

lijieamd
lijieamd reviewed May 20, 2024
View reviewed changes
Copy link

@lijieamd lijieamd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the phi_t in the state vector be theta_t?

@lijieamd
Copy link

@lijieamd @Gopigunaganti @xiao-ge4 Is it possible to review this PR? You can check the updated doc here:

image

@AtsushiSakai
And could you please tell me how to check this CI generated html? It seems like it's an image rather than a link.

@AtsushiSakai
Copy link
Owner Author

AtsushiSakai commented May 20, 2024 •
edited

Could you try to click the "Details" in the CI item. @lijieamd

@AtsushiSakai AtsushiSakai merged commit 5751829 into master May 25, 2024
8 checks passed
@AtsushiSakai AtsushiSakai deleted the issue992 branch May 25, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lijieamd lijieamd lijieamd left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

What is the model used in lqr_steer_control.py?
2 participants
@AtsushiSakai @lijieamd