Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Library injector refactoring #11

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Library injector refactoring #11

wants to merge 2 commits into from

Conversation

dreamer-dead
Copy link
Contributor

This is a complex pull-request, but I think it can be useful to project.
First, I've fixed compilation with Microsoft compiler.
I have almost fixed compilation of the whole Prismatic project with MSVS, so later I can send you patch if you don't mind.
As far as I know it is not a default compiler for this project, but the code is good enough to compile and run using this compiler.
After that, I've made some refactoring to make code simpler. Also I don't like compiler warnings, so I tried to fix most of them.
Hope it can help.

DeadDreamer added 2 commits January 12, 2014 13:55
Fix LibraryInjector compilation with MSVS.
0210405
Project LibraryInjector refactoring.
fdf4618 
- All Dll* functions like DllMain moved to a new file dllmain.c
- Minimized interface of LibraryInjector.h header.
  All implementation details moved to the LibraryInjector.c file.
- Minimized compiler warnings count.
@dreamer-dead
Copy link
Contributor Author

Hi.
Would you provide some reaction for this pull-request, please?
Are you interested in requests like this?

I fixed compilation of Prismatic project with Qt5.2.0 for Win32/MacOS 10.8, you can check my code here - https://github.com/dreamer-dead/Lightpack/commits/fix-compilation-qt5.2.0
During this work I have fixed some errors and I think that you can use my code to make this project better.
So I can make few pull-requests with my fixes. What do you think about this?

@timsat
Copy link
Collaborator

timsat commented Jan 22, 2014

Hi,
Sure i'm interested in your requests! I just working on piece of code for Linux, so i couldn't test the request so quick. I really appreciate your contribution! I'm going to test it on Sunday-Monday and if it is ok it will be released on Tuesday or day after. Other commits/requests will be included to following releases, so shoot .) Thanks again and best regards.

@dreamer-dead
Copy link
Contributor Author

OK, glad to hear that!
I tried not to change any code-flow or logic except error fixes, so I hope that I didn't broke anything.
I'll try to send small changes in every pull-request to make the review simplier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dreamer-dead @timsat