Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core show channels action and minor improvements #274

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

AlexAlexKud
Copy link

Better support CoreShowChannelsAction:

MAIN:
AbstractChannelEvent now inherits ResponseEvent;
CoreShowChannelsAction now inherits ManagerActionEvent;
Added events CoreShowChannelEvent and ;CoreShowChannelsCompleteEvent;

BTW:
Added support for TimeSpan and Guid properies in Parsing and ToString methods;
Added AssemblyInfo attributes autogeneration ignore - this gives build an error in VS 2022

EXAMPLE:
Now you can use CoreShowChannelsAction and receives its responses:

var action = new CoreShowChannelsAction();
var responses = manager.SendEventGeneratingAction(action);

AbstractChannelEvent inherits ResponseEvent;
CoreShowChannelsAction inherits ManagerActionEvent;
Added events CoreShowChannelEvent and ;CoreShowChannelsCompleteEvent;

Added support for TimeSpan and Guid properies;
@Deantwo
Copy link
Collaborator

Deantwo commented May 21, 2023

I can see that you changed indention from four spaces ( ) to taps ( ). This makes the diff kinda annoying to read. Any chance you could change that to spaces?

Of course, now that I think about there, there is a an option to hide whitespaces in the diff.
image

But is is annoying to read the code on GitHub when the indention doesn't match.

@AlexAlexKud
Copy link
Author

AlexAlexKud commented May 22, 2023

I can see that you changed indention from four spaces ( ) to taps ( ). This makes the diff kinda annoying to read. Any chance you could change that to spaces?

Fair remark! Fixed

@AlexAlexKud
Copy link
Author

Comment to get attention
@Deantwo @usender

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants