-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add references in summaries to asterisk docs (manager > actions) #176
base: master
Are you sure you want to change the base?
Conversation
See issue #157 Add Links to Documentation |
will go through these to add line breaks and remove extra white space |
looks good! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are missing some <br/>
tags for newlines.
Some of all the new GitHub changes makes reviewing these pull requests a lot easier.
So if these are fixed it shouldn't be too hard to review it again.
string chargingrAssociationPlan) | ||
string chargingAssociationPlan) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why was this parameter renamed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this is a bug fix in the middle of a documentation pull request?
According to Asterisk 14 ManagerAction_AOCMessage, it should indeed be chargingAssociationPlan
.
Please keep a pull request on-topic. Looking for minor bug fixes in the middle of a huge documentation change is how bugs happen.
/// Available since Asterisk 1.2 | ||
/// | ||
/// Deprecated in Asterisk 1.4 | ||
/// Removed in Asterisk 1.6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need <br/>
for newline.
/// Starts recording a specified conference, with an optional filename. | ||
/// If recording is already in progress, an error will be returned. | ||
/// If RecordFile is not provided, the default record_file as specified in the conferences Bridge Profile will be used. | ||
/// If record_file is not specified, a file will automatically be generated in Asterisk's monitor directory. | ||
/// | ||
/// See <see target="_blank" href="https://wiki.asterisk.org/wiki/display/AST/Asterisk+16+ManagerAction_ConfbridgeStartRecord">https://wiki.asterisk.org/wiki/display/AST/Asterisk+16+ManagerAction_ConfbridgeStartRecord</see> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need <br/>
for newline.
/// Creates an empty file in the configuration directory. | ||
/// This action will create an empty file in the configuration directory. This action is intended to be used before an | ||
/// UpdateConfig action. | ||
/// | ||
/// See <see target="_blank" href="https://wiki.asterisk.org/wiki/display/AST/Asterisk+16+ManagerAction_CreateConfig">https://wiki.asterisk.org/wiki/display/AST/Asterisk+16+ManagerAction_CreateConfig</see> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need <br/>
for newline.
/// Creates a new DBDelAction that deletes the value of the database entry | ||
/// with the given key in the given family. | ||
/// | ||
/// See <see target="_blank" href="https://wiki.asterisk.org/wiki/display/AST/Asterisk+16+ManagerAction_DBDel">https://wiki.asterisk.org/wiki/display/AST/Asterisk+16+ManagerAction_DBDel</see> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need <br/>
for newline.
/// | ||
/// See <see target="_blank" href="https://wiki.asterisk.org/wiki/display/AST/Asterisk+16+ManagerAction_ConfbridgeSetSingleVideoSrc">https://wiki.asterisk.org/wiki/display/AST/Asterisk+16+ManagerAction_ConfbridgeSetSingleVideoSrc</see> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need <br/>
for newline.
/// | ||
/// See <see target="_blank" href="https://wiki.asterisk.org/wiki/display/AST/Asterisk+16+ManagerAction_ConfbridgeStopRecord">https://wiki.asterisk.org/wiki/display/AST/Asterisk+16+ManagerAction_ConfbridgeStopRecord</see> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need <br/>
for newline.
/// | ||
/// See <see target="_blank" href="https://wiki.asterisk.org/wiki/display/AST/Asterisk+16+ManagerAction_ConfbridgeUnlock">https://wiki.asterisk.org/wiki/display/AST/Asterisk+16+ManagerAction_ConfbridgeUnlock</see> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need <br/>
for newline.
/// | ||
/// See <see target="_blank" href="https://wiki.asterisk.org/wiki/display/AST/Asterisk+16+ManagerAction_ConfbridgeUnmute">https://wiki.asterisk.org/wiki/display/AST/Asterisk+16+ManagerAction_ConfbridgeUnmute</see> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need <br/>
for newline.
/// | ||
/// See <see target="_blank" href="https://wiki.asterisk.org/wiki/display/AST/Asterisk+16+ManagerAction_CoreSettings">https://wiki.asterisk.org/wiki/display/AST/Asterisk+16+ManagerAction_CoreSettings</see> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need <br/>
for newline.
No description provided.