Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Animating article items being dismissed #688

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
+50 −17
Open

Animating article items being dismissed #688

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9621f1e
Animating article items being dismissed
savvasdalkitsis Apr 18, 2024
f722eda
Animating article headers being dismissed
savvasdalkitsis Apr 19, 2024
280d3dc
Using latest compose BOM to potentially fix dismiss animation bugs
savvasdalkitsis May 6, 2024
ebfbac7
Using alpha/beta compose BOM to fix item removal leaving empty spaces…
savvasdalkitsis May 6, 2024
39e82c5
Not animating sticky header to fix performance issues
savvasdalkitsis May 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions app/src/main/java/me/ash/reader/ui/page/home/flow/ArticleItem.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,6 +240,7 @@ private const val SwipeActionDelay = 300L
@OptIn(ExperimentalMaterial3Api::class, ExperimentalComposeUiApi::class)
@Composable
fun SwipeableArticleItem(
modifier: Modifier = Modifier,
articleWithFeed: ArticleWithFeed,
isFilterUnread: Boolean = false,
articleListTonalElevation: Int = 0,
Expand Down Expand Up @@ -333,6 +334,7 @@ fun SwipeableArticleItem(
var menuOffset by remember { mutableStateOf(Offset(0f, 0f)) }

SwipeToDismissBox(
modifier = modifier,
state = swipeState,
enabled = !isSwipeEnabled(),
/*** create dismiss alert background box */
Expand Down
1 change: 1 addition & 0 deletions app/src/main/java/me/ash/reader/ui/page/home/flow/ArticleList.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ fun LazyListScope.ArticleList(
is ArticleFlowItem.Article -> {
item(key = item.articleWithFeed.article.id) {
SwipeableArticleItem(
modifier = Modifier.animateItemPlacement(),
articleWithFeed = item.articleWithFeed,
isFilterUnread = isFilterUnread,
articleListTonalElevation = articleListTonalElevation,
Expand Down
Loading