Basic x112virtgpu support #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asahilina
requested review from
slp,
teohhanhui and
alyssarosenzweig
as code owners
alyssarosenzweig
approved these changes
Oct 3, 2024
slp
requested changes
Oct 4, 2024
asahilina
force-pushed
the
x112virtgpu
branch
from
5a65576 to
e713f25
Compare
asahilina
force-pushed
the
x112virtgpu
branch
from
e713f25 to
5cb8b1d
Compare
This lets us easily test this alternative to sommelier+XWayland without committing to making it the default. Signed-off-by: Asahi Lina <[email protected]>
Signed-off-by: Asahi Lina <[email protected]>
asahilina
force-pushed
the
x112virtgpu
branch
from
5cb8b1d to
84730c8
Compare
|
Added another commit to make this mutually exclusive with sommelier, and enabled with the This also fixes dumb stuff like sommelier setting |
asahilina
force-pushed
the
x112virtgpu
branch
from
0979707 to
be42187
Compare
teohhanhui
reviewed
Oct 30, 2024
Instead of enabling X11 forwarding unconditionally but hiding it behind the HOST_DISPLAY variable, enable it if the --direct-x11 flag is used. In that case, directly set it as the DISPLAY environment variable. This makes it easier for users to enable the feature and use it correctly. Eventually, we can flip the logic of the flag to make direct X11 the default. Keep the server at :1 to keep churn down, and because it seems like a generally helpful distinction, since the server is usually :0 on the host. Signed-off-by: Asahi Lina <[email protected]>
asahilina
force-pushed
the
x112virtgpu
branch
from
be42187 to
911448f
Compare
teohhanhui
approved these changes
Oct 30, 2024
slp
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the trivial X11 socket passthrough with x112virtgpu, if it is installed and DAX is enabled. This lives alongside the existing sommelier solution, so we can test both options for now.