Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fn_clearVehicleAmmo.sqf #734

Open
wants to merge 2 commits into
base: v5.X.X
Choose a base branch
from

Conversation

FlorianGH
Copy link

Changes proposed in this pull request:

  • Changed If to switch

  • I have tested my changes and corrected any errors found

It's just a little thing but it needs to be done.

@blackfisch
Copy link
Contributor

moving the clearWeaponCargoGlobal _vehicle; to the top and using exitWith instead of then (or a switch) would actually be the best solution considering performance

_vehicle removeMagazinesTurret ["2000Rnd_65x39_Belt_Tracer_Red",[1]];
_vehicle removeMagazinesTurret ["2000Rnd_65x39_Belt_Tracer_Red",[2]];
};
private ["_vehicle","_veh"];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've managed to duplicate these 3 lines twice. It'd be best to remove the BIS_fnc_param and the private ARRAY and replace with params (obviously removing the duplication).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants