Gameplay: Adjust particle settings #16
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed TapParticle lifetime and their size Make TextParticle have uniform offset from HitParticle Moved TextParticle offset calculation to the ParticleSystem
0thElement
force-pushed
the
master
branch
3 times, most recently
from
3d17ef6
to
9a93f2b
Compare
0thElement
force-pushed
the
master
branch
2 times, most recently
from
8eeb0f3
to
e574e69
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed TapParticle lifetime and their size
Referencing from official game, their particle is bigger and it stays longer than the current settings in ArcCreate.
This commit try to conform the settings from the official game.
Make TextParticle have uniform offset from HitParticle
When in different display ratio, the y position of TextParticle tends to be higher in 4:3.
This commit mitigates it by moving TextParticle offset calculation to the ParticleSystem.