Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deserialize to the base type if the castable type is not defined in code #128

Merged

Conversation

Archomeda
Copy link
Owner

Fixes #120

Allowing strict type checking on request seemed to much of an effort to support for now. So instead it now never throws an exception in the case when a castable type is not defined for a new enum value.

@Archomeda Archomeda added Type: Bug Something isn't working Area: Web API v2 Related to the v2 web API labels Feb 28, 2023
@Archomeda Archomeda merged commit 5c126f1 into master Feb 28, 2023
@Archomeda Archomeda deleted the fix/do-not-throw-exceptions-for-unsupported-castable-type branch February 28, 2023 22:17
@sonarcloud
Copy link

sonarcloud bot commented Feb 28, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Web API v2 Related to the v2 web API Type: Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow less strict type casting when a type doesn't exist
1 participant