Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow less strict type casting when a type doesn't exist #120

Closed
Archomeda opened this issue May 20, 2022 · 0 comments · Fixed by #128
Closed

Allow less strict type casting when a type doesn't exist #120

Archomeda opened this issue May 20, 2022 · 0 comments · Fixed by #128
Labels
Area: Web API v2 Related to the v2 web API Priority: High High priority Resolution: Fixed The issue has been fixed Type: Feature An addition to the project

Comments

@Archomeda
Copy link
Owner

Archomeda commented May 20, 2022

Currently when a CastableType doesn't exist, Gw2Sharp throws an exception like System.Text.Json.JsonException: Unsupported type Quux. This is unhelpful when new content gets added, because this requires an update of Gw2Sharp before stuff works again.

This checking should be less strict. If a type doesn't exist, the base class should be used instead. There should be an option to enable strict type casting (useful for testing), but the default should be set to false.

Ref #117

@Archomeda Archomeda added Type: Feature An addition to the project Priority: High High priority Area: Web API v2 Related to the v2 web API labels May 20, 2022
@Archomeda Archomeda added the Resolution: Fixed The issue has been fixed label Feb 28, 2023
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Web API v2 Related to the v2 web API Priority: High High priority Resolution: Fixed The issue has been fixed Type: Feature An addition to the project
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant