Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: out of text range while composing error #979

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kyungilcho
Copy link

Problem:

Screen_Recording_20241202-230013.mp4

Re-positioning the cursor in the middle of sentence while composing occurs following error.

스크린샷 2024-12-02 오후 11 00 51

so I add logic for checking validity of cursor position.

Copy link

codecov bot commented Dec 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.25%. Comparing base (817c965) to head (c8b245b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #979   +/-   ##
=======================================
  Coverage   72.25%   72.25%           
=======================================
  Files         318      318           
  Lines       15132    15134    +2     
=======================================
+ Hits        10933    10935    +2     
  Misses       4199     4199           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LucasXu0
Copy link
Collaborator

LucasXu0 commented Dec 4, 2024

@kyungilcho Your PR may fix the composing error, but I think the attached position is still incorrect. The position is empty if the assertion happens.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants