Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: custom share url, publish url and copy link to share #7061

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

LucasXu0
Copy link
Collaborator

@LucasXu0 LucasXu0 commented Dec 26, 2024

Feature Preview

  • add a text field to customize the share domain if users are in self-hosted mode
    • settings page (desktop)
    • login page (desktop)
    • settings page (mobile)
    • login page (mobile)
  • replace the share URL
  • replace the publish URL
  • replace the "copy link to block" URL
  • tests
Screenshot 2024-12-26 at 15 48 40 Screenshot 2024-12-26 at 15 48 44 Screenshot 2024-12-26 at 15 48 53 Screenshot 2024-12-26 at 15 49 07

PR Checklist

  • My code adheres to AppFlowy's Conventions
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

Copy link

github-actions bot commented Dec 26, 2024

🥷 Ninja i18n – 🛎️ Translations need to be updated

Project /project.inlang

lint rule new reports level link
Missing translation 56 warning contribute (via Fink 🐦)

Copy link

codecov bot commented Dec 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.41%. Comparing base (7db11c7) to head (0137899).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7061      +/-   ##
==========================================
- Coverage   64.44%   64.41%   -0.03%     
==========================================
  Files         280      280              
  Lines       10738    10738              
  Branches     1449     1449              
==========================================
- Hits         6920     6917       -3     
- Misses       3646     3648       +2     
- Partials      172      173       +1     
Flag Coverage Δ
appflowy_web_app 64.41% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant