fix: toolbar menu not showing beacase keyboard height is not updated in time #7060
+11
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LucasXu0
reviewed
Dec 27, 2024
| /// there will be an issue with the height being 0 | ||
| /// this is used to globally record the height. | ||
| static double _maxKeyboardHeight = 0.0; | ||
| ValueNotifier<double> cachedKeyboardHeight = |
There was a problem hiding this comment.
If _maxKeyboardHeight is used as the initial value every time, cachedKeyboardHeight will never be 0 after the first initialization. I assume this might have side effects on other logic, such as closing the keyboard.
There was a problem hiding this comment.
cachedKeyboardHeight is used to keep the same height when the menu is shown, and it was controlled by canUpdateCachedKeyboardHeight, after _MobileToolbar disposed and recreated a new one, cachedKeyboardHeight will be set to 0, that will cause the issue —— #7049， and using _globalCachedKeyboardHeight can prevent the issue caused by its rapid re-initialization before the height can be obtained
.../plugins/document/presentation/editor_plugins/mobile_toolbar_v3/appflowy_mobile_toolbar.dart
Outdated
Show resolved
Hide resolved
asjqkkkk
force-pushed
the
fix/keyboard
branch
from
08c92a7 to
18f6e82
Compare
asjqkkkk
force-pushed
the
fix/keyboard
branch
from
18f6e82 to
c39df1b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #7049
Feature Preview
PR Checklist