Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: project management & document editor features on web #7051

Open
wants to merge 82 commits into
base: main
Choose a base branch
from

Conversation

qinluhe
Copy link
Collaborator

@qinluhe qinluhe commented Dec 26, 2024

PR: Project Management & Document Editor Features

Features:

  1. Basic Project Management
  • Create space
  • Manage space
  • New page
  • Move page
  • Delete page
  • Share
  • Login & Logout
  • Trash
  1. Document Editor
  • Real-time editing
  • Auto-save to cloud
  • Blocks support
  • Toolbar & slash/mention command
  1. Quick Note
  • Fast note creation

Testing:

  • Unit tests for core functions
  • Component tests for main flows

Please review the code changes and check the test coverage.


PR Checklist

  • My code adheres to AppFlowy's Conventions
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

Copy link

github-actions bot commented Dec 26, 2024

🥷 Ninja i18n – 🛎️ Translations need to be updated

Project /project.inlang

lint rule new reports level link
Missing translation 2632 warning contribute (via Fink 🐦)

@qinluhe qinluhe force-pushed the feat/support-document-editing branch 8 times, most recently from 5f0e4f7 to 9d4f40f Compare December 26, 2024 05:27
Copy link

codecov bot commented Dec 26, 2024

Codecov Report

Attention: Patch coverage is 40.83115% with 2036 lines in your changes missing coverage. Please review.

Project coverage is 57.74%. Comparing base (171c563) to head (168d768).
Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
..._web_app/src/application/slate-yjs/utils/editor.ts 32.72% 653 Missing and 11 partials ⚠️
...owy_web_app/src/application/slate-yjs/utils/yjs.ts 50.20% 363 Missing and 9 partials ⚠️
.../application/services/js-services/http/http_api.ts 1.29% 152 Missing ⚠️
...web_app/src/application/slate-yjs/command/index.ts 50.00% 54 Missing and 7 partials ⚠️
...ponents/block-popover/ImageBlockPopoverContent.tsx 0.00% 61 Missing ⚠️
...onents/editor/components/blocks/file/FileBlock.tsx 0.00% 51 Missing ⚠️
...mponents/block-popover/FileBlockPopoverContent.tsx 0.00% 44 Missing ⚠️
.../src/components/_shared/icon-picker/IconPicker.tsx 6.81% 41 Missing ⚠️
...p/src/components/_shared/image-upload/Unsplash.tsx 4.65% 41 Missing ⚠️
..._app/src/application/services/js-services/index.ts 72.53% 39 Missing ⚠️
... and 52 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7051      +/-   ##
==========================================
- Coverage   64.41%   57.74%   -6.67%     
==========================================
  Files         280      320      +40     
  Lines       10738    14033    +3295     
  Branches     1449     2040     +591     
==========================================
+ Hits         6917     8104    +1187     
- Misses       3648     5664    +2016     
- Partials      173      265      +92     
Flag Coverage Δ
appflowy_web_app 57.74% <40.83%> (-6.67%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@qinluhe qinluhe force-pushed the feat/support-document-editing branch 7 times, most recently from a6c7c6f to aa10b98 Compare December 26, 2024 10:15
@qinluhe qinluhe force-pushed the feat/support-document-editing branch from aa10b98 to 168d768 Compare December 26, 2024 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant