Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete previous image on cover change #6368

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
+99 −3
Open

delete previous image on cover change #6368

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
bd9be43
remove unecessary images from localstorage
Ahad-patel Oct 17, 2024
5ca7cbc
Merge branch 'main' into delete-unecessary-images
Ahad-patel Oct 17, 2024
86ba1ee
Merge branch 'main' into delete-unecessary-images
Ahad-patel Oct 21, 2024
5c6b18b
feat: Add handler for deleting previous cover image on cover image ch…
Ahad-patel Oct 21, 2024
bf6b3ef
fix: add local image case for versions after 0.5.5
Ahad-patel Oct 21, 2024
e668352
fix: add try catch block and delete action to bottom of function
Ahad-patel Oct 22, 2024
093ec2a
Merge branch 'main' into delete-unecessary-images
Ahad-patel Oct 30, 2024
86ffa67
chore: add test case for uploading and deleting image in localmode
Ahad-patel Oct 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions ...lutter/lib/plugins/document/presentation/editor_plugins/header/document_cover_widget.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -763,6 +763,7 @@ class DocumentCoverState extends State<DocumentCover> {
}

Future<void> onCoverChanged(CoverType type, String? details) async {
await deletePreviousImageIfNecessary();
Copy link
Collaborator

@Xazin Xazin Oct 21, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can perform this after changing the cover. (Since it's an asynchronous operation)

if (type == CoverType.file && details != null && !isURL(details)) {
if (_isLocalMode()) {
details = await saveImageToLocalStorage(details);
Expand All @@ -774,6 +775,20 @@ class DocumentCoverState extends State<DocumentCover> {
widget.onChangeCover(type, details);
}

Future<void> deletePreviousImageIfNecessary() async {
final previousType = CoverType.fromString(
widget.node.attributes[DocumentHeaderBlockKeys.coverType]);
final previousDetails =
widget.node.attributes[DocumentHeaderBlockKeys.coverDetails];

bool isFileType(CoverType type, String? details) =>
type == CoverType.file && details != null && !isURL(details);

if (isFileType(previousType, previousDetails) && _isLocalMode()) {
await deleteImageFromLocalStorage(previousDetails);
}
}

void setOverlayButtonsHidden(bool value) {
if (isOverlayButtonsHidden == value) return;
setState(() {
Expand Down
4 changes: 4 additions & 0 deletions ...d/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/image/image_util.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,3 +117,7 @@ Future<List<ImageBlockData>> extractAndUploadImages(

return images;
}

Future<void> deleteImageFromLocalStorage(String localImagePath) async {
await File(localImagePath).delete();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we wrap this in try-catch and at least log errors?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

}
8 changes: 8 additions & 0 deletions ..._flutter/lib/plugins/document/presentation/editor_plugins/migration/editor_migration.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,6 +226,14 @@ class EditorMigration {
},
};
}
} else {
extra = {
ViewExtKeys.coverKey: {
ViewExtKeys.coverTypeKey:
PageStyleCoverImageType.localImage.toString(),
ViewExtKeys.coverValueKey: coverDetails,
},
};
}
break;
default:
Expand Down
Loading