-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: reset individual shortcut #5756
base: main
Are you sure you want to change the base?
fix: reset individual shortcut #5756
Conversation
🥷 Ninja i18n – 🛎️ Translations need to be updatedProject
|
lint rule | new reports | level | link |
---|---|---|---|
Missing translation | 108 | warning | contribute (via Fink 🐦) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5756 +/- ##
===========================================
- Coverage 86.74% 75.13% -11.61%
===========================================
Files 217 239 +22
Lines 5032 6464 +1432
Branches 831 1041 +210
===========================================
+ Hits 4365 4857 +492
- Misses 561 1555 +994
+ Partials 106 52 -54
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Should we change the opacity (eg. 70%), change cursor to default, and change the tooltip to "Keybinding is already the default", when the keybinding is already the one it would be after an eventual reset? |
Yes, that sounds right. On it! |
Hey @MayurSMahajan , I've added the behavior I spoke about previously for disabling the button when the keybinding is already the default. |
Oh Thanks! |
@LucasXu0 what is stopping this PR from getting merged? |
Nothing. Give me some time to review it. |
Solves: #5684
Feature Preview
Here is a feature preview:
individual_shortcut.mp4
PR Checklist