Play Sound Instruction for World Logic #9736
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mythril382
changed the title
|
The commit names are so real |
Anuken
reviewed
Apr 24, 2024
| import arc.audio.*; | ||
| import mindustry.gen.*; | ||
|
|
||
| public enum LogicSound{ |
There was a problem hiding this comment.
This is not a good idea. It's just a re-definition of Sounds, and will require maintenance any time a sound is changed or added.
A better alternative would be to have Sounds.java generate a String[] of sound names, and a map of name to sound object.
Or, one could use Core.assets.getAll(Sound.class, ...) for the same purpose. This would be messier, but would not require modifying codegen.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know how to implement loop sounds, so leave suggestions if possible.
If your pull request is not translation or serverlist-related, read the list of requirements below and check each box: