Slag Incinerator Rework: No Slag Consumption Rate #10197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
how did the check fail for a one line change…. |
|
wait I can probably remove the /sec slag and call it a day |
Cause its a workflow issue, anuke needs to update dependacies |
|
Fixed the liquid Display thing, seems complete now |
SomeonesShade
force-pushed
the
balancing_slag-incin-rework
branch
from
71dffef
to
567b515
Compare
…onesShade/Mindustry into balancing_slag-incin-rework
|
my first merge conflict and it somehow caused the pr to close ... |
|
Omg!? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements Anuken/Mindustry-Suggestions#5210
Specifically A1, "Input Slag Once/No Slag Consumption Rate"
Details:
Set Slag Incinerator Consumption rate to:
0fRemoved
/secin Liquid Display if amount is0fSlag Incinerator in Action:
Video:
ra.mov
Liquid Display Fix:
Before:
Seems to be well supported by the discord: https://discord.com/channels/391020510269669376/766777428097105920/127977327314351317
and has already been reviewed at #balancing
Suggestion Alternative B: "Slag Producing Slag Incinerator" might be chosen instead if implementation is possible, if I'm in a position to do it myself, although priority is getting something working/non-controversial first, then follow up if it has support.
If your pull request is not translation or serverlist-related, read the list of requirements below and check each box: