Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing tox Python 3.11 and 3.12 issues #1182

Merged
merged 5 commits into from
Jul 7, 2024
Merged

fixing tox Python 3.11 and 3.12 issues #1182

merged 5 commits into from
Jul 7, 2024

Conversation

captivus
Copy link
Collaborator

@captivus captivus commented Jul 7, 2024

Python 3.11 target doesn't run in tox. Fixing this.

@captivus captivus requested a review from ATheorell as a code owner July 7, 2024 17:50
@captivus captivus changed the title fixing tox Python 3.11 issue fixing tox Python 3.11 and 3.12 issues Jul 7, 2024
@captivus
Copy link
Collaborator Author

captivus commented Jul 7, 2024

The error seems to be due to codecov. Disabling it results in successful run of Python 3.11 target.

The remaining Python 3.12 test errors were due to this Pydantic issue which requires downgrading to Python 3.12.3 to resolve until Pydantic upstream fixes this for > Python 3.12.3. Pinned our tox test installed version of Python 3.12 to 3.12.3.

@captivus captivus merged commit 3bb4a49 into main Jul 7, 2024
5 checks passed
@captivus
Copy link
Collaborator Author

captivus commented Jul 7, 2024

@ATheorell @viborc we need to sort out the codecov rate limit issue. I don't have access to the Codecov account to resolve. When resolved, we can reenable codecov.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant