Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix/docker image #1161

Merged
merged 4 commits into from
Jun 6, 2024
Merged

Hotfix/docker image #1161

merged 4 commits into from
Jun 6, 2024

Conversation

k1lgor
Copy link
Contributor

@k1lgor k1lgor commented May 29, 2024

What's changed

  • docker-compose.yml - version is deprecated
  • docker/Dockerfile - image changed to slim base (Ubuntu)
  • docker/README.md - update with Docker Compose instructions
  • pyproject.toml - add langchain-community python package

This would fix #1136 and maybe #1160

P.S. Sorry for the delayed PR. Everything discussed in #1159 and #1136 implemented
@viborc @captivus @zigabrencic

Copy link
Collaborator

@TheoMcCabe TheoMcCabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - have you tested this locally? Would you like me to run a test build ?

@k1lgor
Copy link
Contributor Author

k1lgor commented May 29, 2024

Indeed, I have. While both git and gpte are executable, I would rather you give it a try to make sure everything works as it should.

@zigabrencic
Copy link
Collaborator

zigabrencic commented May 30, 2024

Hey.

Works on macOS Sonoma with image size at 690.84 MB so.

Fine by me to be merged.

@viborc
Copy link
Collaborator

viborc commented May 30, 2024

Thanks, @zigabrencic.

@TheoMcCabe, can you confirm that it worked fine on your end, too?

@viborc viborc merged commit 1e292f4 into AntonOsika:main Jun 6, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docker build is broken
4 participants