-
-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Formate uploading files with black linting tool #1094
Conversation
# Conflicts: # tests/core/default/test_steps.py
I have a extra request :) I think it would make sense to always run linting by default inside FileStore:push and also run it by default inside FileStore:pull, but in this case, make an optional argument to disable linting |
I support this suggestion as it aligns with best practices for software development. I'm planning to refactor this section in my upcoming PR. Would it be advisable to introduce a return flag at this point in the code? main.pyL456. I'm considering modifying the function to return |
Yes, that sounds great! Actually, such a FileStore object is already initialized in the main at line 453 and could be used for all io-operations. Inside the FileSelector, it would then make sense to use the isLinting variable to toggle whether the FileStore object should lint or not for the case of reading files for improve. |
Overview
This PR aims to address Issue #1023 by integrating code formatting and linting tools into our development workflow. The primary goal is to enhance efficiency and improve the quality of the suggestions provided by LLMs by pre-screening code for errors. This preemptive check reduces the computational demand on LLMs, allowing them to focus on the complexity of tasks rather than basic syntax corrections.
Implementation Details
To minimize the impact on user experience, we plan to implement an automatic linting feature that will be enabled by default during the code processing phase. Users will be informed that their codebase has undergone linting, ensuring transparency. Additionally, we will provide an option for users who prefer not to use the linting tools, respecting diverse development preferences.
Scope and Targets
The initial rollout will focus on supporting Python files. This decision is made to strike a balance between managing dependencies and meeting the feature's requirements efficiently. By starting with these languages, we aim to cover a significant portion of the development activities within our community while keeping the implementation manageable.