Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Fix: my-slider-v2 cover entity - value shown incorrect when using… #62

Merged
merged 1 commit into from
Oct 27, 2024

Conversation

AnthonMS
Copy link
Owner

@AnthonMS AnthonMS commented Oct 27, 2024

… sliderMin config key.

Description

When using sliderMin with a cover entity, the slider was showing it incorrectly. With this change it should be showing the correct progress on the slider.

Related Issue

#61

Motivation and Context

Salves the bug when using cover entities. I am unsure if this fixes it for other entities when using it inversed, because it was an inverse issue.

How Has This Been Tested

Tested locally with the sliderMin config key set in the ui configuration. It didn't seem like it was causing other issues with all the other places where the slider card was used in my setup.

Types of changes

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 🌎 Translation (addition or update a translation)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have tested the change locally.

@AnthonMS AnthonMS merged commit fa9abc8 into main Oct 27, 2024
3 checks passed
@AnthonMS AnthonMS deleted the bug/my-slider-cover-sliderMin-incorrect branch October 27, 2024 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant