Do not use an object for SMTP options

Objects do not appear to work when supplying ecosystem config options, so move the two SMTP options into their own lines in the config
AndrewIsh · Dec 3, 2020 · b88c707 · b88c707
1 parent fe3454c
commit b88c707
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 12 deletions.
diff --git a/ecosystem.config.js.template b/ecosystem.config.js.template
@@ -17,11 +17,8 @@ module.exports = {
                 BASE_URL: '<base_url_of_frontend>',
                 FROM: '<email_from>',
                 REPLY_TO: '<email_reply_to>',
-                // See https://nodemailer.com/smtp/ for all options
-                SMTP_OPTIONS: {
-                    port: '<smtp_port>',
-                    host: '<smtp_server>'
-                }
+                SMTP_HOST: '<smtp_host>',
+                SMTP_PORT: '<smtp_port>'
             },
             env_production: {
                 NODE_ENV: 'production',
@@ -31,11 +28,8 @@ module.exports = {
                 BASE_URL: '<base_url_of_frontend>'
                 FROM: '<email_from>',
                 REPLY_TO: '<email_reply_to>',
-                // See https://nodemailer.com/smtp/ for all options
-                SMTP_OPTIONS: {
-                    port: '<smtp_port>',
-                    host: '<smtp_server>'
-                }
+                SMTP_HOST: '<smtp_host>',
+                SMTP_PORT: '<smtp_port>'
             }
         }
     ]

diff --git a/lib.js b/lib.js
@@ -4,8 +4,11 @@ const nodemailer = require('nodemailer');
 const db = require('../ems-db');
 
 const email = new Email();
-let smtpOptions = JSON.parse(process.env.SMTP_OPTIONS);
-smtpOptions = {...smtpOptions, send: true};
+const smtpOptions = {
+    send: true,
+    host: process.env.SMTP_HOST,
+    port: process.env.SMTP_PORT
+};
 const transporter = nodemailer.createTransport(smtpOptions);
 
 const sendEmail = async ({to, name, queries, type}) => {