Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Multiple categories per transaction #85

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

tufteddeer
Copy link
Contributor

As suggested in #39, it would be nice if we could add more than one category to a transaction.

It's still wip, feedback and thoughts very much appreciated!

@tufteddeer
Copy link
Contributor Author

A (not very pretty) screenshot of 3dda80f:
Screenshot_1570363961

@tufteddeer
Copy link
Contributor Author

Right now transactions are saved one time for each category, so there is no need to mess with all the transaction models, overviews and stuff.

@tufteddeer
Copy link
Contributor Author

@AndreAle94 i would like to continue hacking on this feature if you are okay with the way I'm implementing it, so a little feedback would be appreciated (nothing fancy, just your general impression) 😃

@AndreAle94
Copy link
Owner

Hello, thanks for the contribution. I think it's a good workaround for the moment. However, I don't think it's the best way to implement this feature, so I don't think I will merge this changes into the repository. Managing split transactions in this way can work when a transaction is created, not when the user wants to correct / change something or delete it. Moreover, the transaction list can easily become confusing. The best way in my opinion (but it requires a lot of work both in structuring the db and in modifying all existing queries) is to create an ad hoc structure in the database and manage these transactions as part of a group. These changes must then be reflected throughout the backup file structure. This is why they have not yet been implemented.

@tufteddeer
Copy link
Contributor Author

I agree, that's what i expected. Remodeling the storage backend is too much for me right now but if there's a way to help implementing this feature, I'd like to.

@ghost ghost mentioned this pull request Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants