Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add monochrome icon for android 13 #276

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

rec0de
Copy link

@rec0de rec0de commented Aug 10, 2023

Hi!

I recently updated to android 13 and noticed money wallet does not yet support monochrome icons for theming, which makes the app stick out quite a bit when placed next to other apps that support theming.

Here's a screenshot of money wallet next to some apps that support theming:

wallet

I've added a simple monochrome icon that's pretty close to the current icon.
monochrome

Now, I have to be honest: I was not able to build the app to test locally due to some weird gradle/java version incompatibilities - but since it's just a very simple asset change I'm reasonably confident that it should work. If you do need someone to test on android 13, feel free to send me an apk~

Also, here's the raw SVG of the monochrome icon (white on white preview here so it's hard to spot but it's there):

monochrome

Cheers!

@riScoRpIng
Copy link

riScoRpIng commented Aug 12, 2023

Great, merging this pull request closes issue #263. Hope maintainer will merge this eventually... @AndreAle94

@ahormann
Copy link

ahormann commented Feb 8, 2024

@rec0de
Thank you for this!

due to some weird gradle/java version incompatibilities

Did you try Java8? This did the trick for me.
Alternatively you could try to use the dependency-Updates in DodoLeDevs Fork. With them I can use Java17.

I also tried your icon.
It does not scale properly for me (Stock Android 14), so i see only the center of the wallet in the round icon.
But based on your changes i managed to fix this, now it looks as expected.
Feel free to cherry-pick the respective commits from my fork to include them in your PR, if you want to.

@rec0de
Copy link
Author

rec0de commented Feb 10, 2024

@ahormann glad to see you found some use in it - i think the pull request / the repo is pretty dead however, so i'm not sure its worth updating the PR. Thanks for giving it a try though, i might check out some of the forks to see if i can get a build running

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants