-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(eslint): fix typescript import resolution #2502
fix(eslint): fix typescript import resolution #2502
Conversation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit cce253b. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
@@ -8,12 +14,6 @@ import type { | |||
import { | |||
ESLint, | |||
} from 'eslint'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the imports don't seem to be in alphabetical order
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/AmadeusITGroup/otter/pull/2502/files#diff-4bc2155348e1323d934d8ba058c7cfdef2426d74133eb1281fcc81b1f66e76b9R28
this flag the import as core
import are not only in alphabetical order but also following ["builtin", "external", "internal", "parent", "sibling", "index", "object", "type"]
https://github.com/import-js/eslint-plugin-import/blob/main/docs/rules/order.md
98f24b5
to
cce253b
Compare
cb3ab69
into
feat/migrate-eslint-9-flat-config
No description provided.