Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint): fix typescript import resolution #2502

Merged

Conversation

matthieu-crouzet
Copy link
Contributor

No description provided.

@matthieu-crouzet matthieu-crouzet requested a review from a team as a code owner November 22, 2024 13:47
Copy link

nx-cloud bot commented Nov 22, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit cce253b. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@@ -8,12 +14,6 @@ import type {
import {
ESLint,
} from 'eslint';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the imports don't seem to be in alphabetical order

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/AmadeusITGroup/otter/pull/2502/files#diff-4bc2155348e1323d934d8ba058c7cfdef2426d74133eb1281fcc81b1f66e76b9R28
this flag the import as core
import are not only in alphabetical order but also following ["builtin", "external", "internal", "parent", "sibling", "index", "object", "type"]
https://github.com/import-js/eslint-plugin-import/blob/main/docs/rules/order.md

@matthieu-crouzet matthieu-crouzet merged commit cb3ab69 into feat/migrate-eslint-9-flat-config Nov 22, 2024
2 checks passed
@matthieu-crouzet matthieu-crouzet deleted the fix/eslint-import-resolver branch November 22, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment