Added a config parameter auto.create.tables.replicated
#345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s replicated tables creation. In this logic I use a separate config parameter `use.replacingmergetree.is_deleted.column` as a flag to manage tables creation. If `true` - use `is_deleted` column if supported, otherwise use `_sign`.
subkanthi
reviewed
Oct 25, 2023
| @@ -75,12 +90,42 @@ public java.lang.String createTableSyntax(ArrayList<String> primaryKey, String t | |||
| //createTableSyntax.deleteCharAt(createTableSyntax.lastIndexOf(",")); | |||
|
|
|||
| // Append sign and version columns | |||
| createTableSyntax.append("`").append(SIGN_COLUMN).append("` ").append(SIGN_COLUMN_DATA_TYPE).append(","); | |||
| String DeleteColumnNameFinal = this.userDefinedDeleteColumnName; | |||
There was a problem hiding this comment.
please use camel case for variables.
There was a problem hiding this comment.
DeleteColumnNameFinal is not a constant, and it should not start with upper case.
There was a problem hiding this comment.
OK, my bad, sorry)
subkanthi
reviewed
Oct 25, 2023
| createTableSyntax.append(")"); | ||
| createTableSyntax.append(" "); | ||
| createTableSyntax.append("ENGINE = ReplacingMergeTree(").append(VERSION_COLUMN).append(")"); | ||
| createTableSyntax.append("ENGINE = "); |
There was a problem hiding this comment.
Please update unit tests in ClickHouseAutoCreateTableTest.
|
In my environment I use |
|
This feature was implemented as part of other PRs , closing this for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution for #62. Added a config parameter
auto.create.tables.replicatedthat controls replicated tables creation.In this logic I use a separate config parameter
use.replacingmergetree.is_deleted.columnas a flag to manage tables creation. Iftrue- useis_deletedcolumn if supported, otherwise use_sign.