Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the getVersionColumnForReplacingMergeTree() to support replicated tables properly #343

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

Fix the getVersionColumnForReplacingMergeTree() to support replicated tables properly #343

wants to merge 5 commits into from

Commits on Oct 25, 2023

  1. 1. In the current logic the getVersionColumnForReplacingMergeTree() r… 

    …eturns only version_column from a replicated table definition (here `versionColumn = parameterArray[2].trim();`), but a is_deleted column migth be there too.

2. It's unnecessary to have separate if clauses for replicated and nonreplicated tables, we can union them.
    Илья Захаров (ilia.zakharov) committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    fd4d655 View commit details
    Browse the repository at this point in the history

  2. Edited tests

    Илья Захаров (ilia.zakharov) committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    ad619f5 View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2023

  1. Small fixes

    @IlyaTsoi
    IlyaTsoi committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    695f091 View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2023

  1. Merge branch 'develop' into fix_dbmetadata_retrieving

    @subkanthi
    subkanthi authored Oct 31, 2023
    Configuration menu
    Copy the full SHA
    43d8022 View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2023

  1. Merge branch 'develop' into fix_dbmetadata_retrieving

    @subkanthi
    subkanthi authored Nov 7, 2023
    Configuration menu
    Copy the full SHA
    6c76f11 View commit details
    Browse the repository at this point in the history