Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Smooth Scrolling + Fixed Navigation Bar #131

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Smooth Scrolling + Fixed Navigation Bar #131

wants to merge 3 commits into from

Conversation

hardikchopra242
Copy link

I made 3 commits

  1. In the first commit, I numbered all the protips.
  2. In the second commit, I added protip for Smooth-Scrolling
  3. In the third commit, I added protip for Fixed navigation bar.

@AllThingsSmitty
Copy link
Owner

Thanks for the PR. There's no need to number the tips, I've intentionally avoided that.

About your suggestions for tips: scroll-behavior and position: sticky both have limited support across modern browsers. While they are both interesting options, I'm not sure they're a good fit for this list. Let me think about it for a bit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hardikchopra242 @AllThingsSmitty