Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cross-Validation-from-Scratch #114 #166

Closed
wants to merge 1 commit into from
Closed

Cross-Validation-from-Scratch #114 #166

wants to merge 1 commit into from

Conversation

Dishita2602
Copy link
Contributor

@Dishita2602 Dishita2602 commented Apr 20, 2021

I have code for 4 methods involved for cross validation.
Leave One Out (Linear Reg)
Leave P Out (Linear Reg)
K fold (Log Reg)
K Stratifiedfold (Log Reg)

Please review it.

(Sorry it's issue #114 )

@Dishita2602 Dishita2602 changed the title Cross-Validation-from-Scratch #144 Cross-Validation-from-Scratch #114 Apr 20, 2021
@ashwanirathee
Copy link
Collaborator

Not a class type implementation, @Dishita2602 Please add a class type implementation

@ashwanirathee ashwanirathee added gssoc21 GirlScript Summer Of Code 2021 Level2 Bug fixing, adding small features labels Apr 27, 2021
@Dishita2602
Copy link
Contributor Author

Not a class type implementation, @Dishita2602 Please add a class type implementation

Can you please be more clearer ?

@geekquad
Copy link
Member

Hey @Dishita2602,
please go through the Contributing Guidelines.
We need a class-type implementation of the algorithm/technique from scratch using nothing but NymPy.
No external modules/libraries are allowed.
To know more about classes in Python please refer here.

@Dishita2602
Copy link
Contributor Author

Hey @Dishita2602,
please go through the Contributing Guidelines.
We need a class-type implementation of the algorithm/technique from scratch using nothing but NymPy.
No external modules/libraries are allowed.
To know more about classes in Python please refer here.

Issue was not created by me so I was not knowing that you guys are only looking for cross-validation implementation without any libraries. Also I had commented in issue that I am going to use these 4 methods but nobody replied to it. That's why I did PR as per my understanding.

@geekquad
Copy link
Member

Hey @Dishita2602,
please go through the Contributing Guidelines.
We need a class-type implementation of the algorithm/technique from scratch using nothing but NymPy.
No external modules/libraries are allowed.
To know more about classes in Python please refer here.

Issue was not created by me so I was not knowing that you guys are only looking for cross-validation implementation without any libraries. Also I had commented in issue that I am going to use these 4 methods but nobody replied to it. That's why I did PR as per my understanding.

Hey @Dishita2602,
we might have missed that, apologies. But we have mentioned everything in the Contributing Guidelines.
Please make the amendments in the current code-base. Thank you.

@geekquad geekquad removed Level2 Bug fixing, adding small features gssoc21 GirlScript Summer Of Code 2021 labels May 21, 2021
@geekquad
Copy link
Member

Hey @Dishita2602, you willing to complete it?

@ashwanirathee
Copy link
Collaborator

This doesn't follow the contributing guidelines mentioned and PR creatrr is inactive. Hence closing this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants