background color changed #338
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
harikesh409
requested changes
Apr 4, 2021
| <div class="main"> | ||
| <div class="links"> | ||
| <div class="pages"> | ||
| <a href="https://algo-phantoms.github.io/Algo-Phantoms-Frontend/#about">About Page</a> |
There was a problem hiding this comment.
Instead of hardcoding the links use dynamic links like index.html, index.html#about.
| <div class="footerinfo">Created by | ||
| <a href="https://www.cratonik.com/" target="_blank">Chaitanya Shimpi</a> | ||
| <!--========================== Footer starts here =========================--> | ||
| <div class="footer">Copyright © 2021 <a href="#" style="color: #3caea3; text-decoration: none;" target="_blank"><span class="font-weight-bold">AlgoPhantoms.</span></a> All Rights Reserved</div> |
There was a problem hiding this comment.
Instead of inline styles use the stylesheet.
| <div class="footerinfo">Created by | ||
| <a href="https://www.cratonik.com/" target="_blank">Chaitanya Shimpi</a> | ||
| <!--========================== Footer starts here =========================--> | ||
| <div class="footer">Copyright © 2021 <a href="#" style="color: #3caea3; text-decoration: none;" target="_blank"><span class="font-weight-bold">AlgoPhantoms.</span></a> All Rights Reserved</div> |
There was a problem hiding this comment.
Point the link to index.html.
| <a href="https://algo-phantoms.github.io/Algo-Phantoms-Frontend/#footer">Contact Page</a> | ||
| </div> | ||
| <div class="features"> | ||
| <a href="https://www.codechef.com/ide">Code Editor</a> |
There was a problem hiding this comment.
No need to keep third party links in the sitemap file.
|
@tier3guy are the changes done? |
|
Sir give me one more day , PLZZ , I am raising the PR by tomorrow . |
Any progress, if not I will assign it to somebody else. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes : #278
