Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Useful Resources #296

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Conversation

rupal121
Copy link

@rupal121 rupal121 commented Mar 30, 2021

Description

Added a new webpage in the more drop-down menu. This webpage contains various free resources related to DSA, tech stacks, programming languages and contains suggestions of helpful websites for cse students.

Fixes #244

List any dependencies that are required for this change

Type of change

  • [* ] New feature (non-breaking change which adds functionality)

How Has This Been Tested?

UI /UX changes

Attach gif or screenshot for changes.
- After
2021-03-31

Checklist:

  • [ *] My code follows the style guidelines of this project
  • [* ] I have performed a self-review of my own code
  • [ *] I have commented my code, particularly in hard-to-understand areas
  • [ *] My changes generate no new warnings
  • [* ] I have added tests that prove my fix is effective or that my feature works
  • [ *] New and existing unit tests pass locally with my changes

Added some free good resources for cse students
@rupal121
Copy link
Author

Kindly review @harikesh409

index.html Outdated Show resolved Hide resolved
Useful_Resources.html Outdated Show resolved Hide resolved
<title>Useful Resources</title>
<meta name="viewport" content="width=device-width, initial-scale=1">
<style type="text/css">
* {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use existing styles for uniformity across pages.

<html lang="en">
<head>
<title>Useful Resources</title>
<meta name="viewport" content="width=device-width, initial-scale=1">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add other meta tags and favicons present in index.html.

Copy link
Collaborator

@harikesh409 harikesh409 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Pull the latest changes from master branch and merge many changes are being missed.
  • Remove the resources_style.css file which is not needed we can reuse the existing style.css without modify it.

@@ -0,0 +1,69 @@
* {
box-sizing: border-box;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Repeated property already present in style.css

* {
box-sizing: border-box;
}
h1{
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be replaced with bootstrap text-center class.

}


.left {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use bootstrap containers instead of this

margin-left: 10%;
margin-right: 5%;
}
.right {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use bootstrap containers and layouts

}
body{
color: white;
background-image: url(video/background.gif);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The link is wrong and use inline styles as used in index.html.

<div class="col-lg-2 col-md-2 col-sm-6 col-12 offset-lg-1">
<h5 class="font-weight-bold text-white mb-lg-4 pb-2 margin-top-mobile">Useful Links</h5>
<ul>
<a class="text-white mb-lg-3" href="#about">About</a><br>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should point to the about section in index page.

<h5 class="font-weight-bold text-white mb-lg-4 pb-2 margin-top-mobile">Useful Links</h5>
<ul>
<a class="text-white mb-lg-3" href="#about">About</a><br>
<a class="text-white mb-lg-3" href="./team.html">Our Team</a><br>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make it team.html

<a class="text-white mb-lg-3" href="#about">About</a><br>
<a class="text-white mb-lg-3" href="./team.html">Our Team</a><br>
<a class="text-white mb-lg-3" href="#footer">Contact</a><br>
<a class="text-white mb-lg-3" href="./sitemap.html">SiteMap</a>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make it sitemap.html


<div class="col-lg-3 col-md-3 col-sm-6 col-12">
<h5 class="font-weight-bold text-white mb-lg-4 pb-2 margin-top-mobile">Follow Us</h5>
<a href="#" target="_blank"><i class="fa fa-github p-2 text-white" aria-hidden="true"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Point to the github repo.

</div>
<hr style="background: white;" class="mt-5">
<div class="text-center text-white mt-lg-4 pt-lg-2 copyright-text">
Copyright &copy; 2021 <a href="#" style="color: #3caea3; text-decoration: none;" target="_blank"><span
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Point to index.html

@harikesh409
Copy link
Collaborator

image
The content is being overflowed, mostly this will be resolved if used bootstrap layouts properly.

@harikesh409
Copy link
Collaborator

@rupal121 what is the progress for the changes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Want to add link to new page where good free courses related to DSA are available.
2 participants