-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed the social-sidebar overlaping in smaller devices and styled the DSA roadmap page. #185
base: master
Are you sure you want to change the base?
Conversation
@abstrxtInfinity please makes the requested changes |
@abstrxtInfinity resolve the merge conflicts. |
@harikesh409 I have resolved the conflicts and did the changes I was asked to do. |
The DSA problems page was so simple. I want to revamp it please assign it to me @harikesh409 @ravikr126 |
@abstrxtInfinity please remove conflicts and then msg me on discord. |
conflicts resolved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.round-2 { | ||
position: absolute; | ||
top: 50%; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Closing of the style is missing.
margin-right:6rem; | ||
} | ||
|
||
|
||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Invalid closing bracket.
.copyright-text { | ||
font-size: 14px; | ||
letter-spacing: 0.6px !important; | ||
} | ||
|
||
|
||
font-size: 14px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For which property are you assigning the styles?
.margin-top-mobile { | ||
padding-top: 15px; | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unnecessary extra closing bracket.
color: #fff; | ||
font-size: 4rem; | ||
margin-left: 2vw; | ||
position: absolute; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct indentations and check the styles in different resolutions as I can see that the typing text is being overlapped.
remove all conflicts @abstrxtInfinity |
@ravikr126 @harikesh409 I'm sorry I was unable to remove the conflicts on time because of some personal reasons at home ( I am infected with Covid-19). I would suggest you kindly assign someone else to remove the conflicts on my behalf. |
#179 issue fixed.
#183 issue fixed.