Fix ble006 for the new converter format #1352
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@AlexxIT please let me know if there is any concerns on this PR. The PR has been working very well for me for the last few weeks. And I also put an article in Chinese that share my experience around this device in a Chinese Home Assistant forum https://bbs.hassbian.com/thread-25298-1-1.html with a video demo there. |
|
Sorry. Haven't looked at it yet. So many other projects. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@AlexxIT think you had a different interpertation of data of the knob event this device reports when you converts to the new format. I have rewrote it. Please see comments in the code for details.
Feel free to streamline the code or the event name if we can make it shorter without being hard to undersrtand.