feat: new disableTransform prop to use top/left instead of translate
#138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xed position item A small change for a particular use case. The css Transform property create a new scope inside the browser, so the item with fixed position is positioned relatively to the nearest parent with the transform property (.vue-recycle-scroller__item-view) and not the browser itself. Here I'm adding a "modal" property the the item object, when set to true, it replace "transform (x or y)" with "left or top" depending on the "direction" also unset the css "will-change" property. Typical use case : zoom in modal for images or video display
Closed
ploissken
pushed a commit
to ploissken/vue-virtual-scroller
that referenced
this pull request
Jan 7, 2020
|
aby updates on this pull request, might be useful for dynamic scroller as well |
|
Hello, can this be merged? I have this issue |
louisraetz
approved these changes
Apr 26, 2022
|
I'm not sure we want to change this as it might degrade performance. |
❌ Deploy Preview for vue-virtual-scroller-demo failed.
|
Akryum
changed the title
disableTransform prop to use top/left instead of translate
|
@Akryum Which version of the package contains this fix please ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small change for a particular use case.
The css Transform property create a new scope inside the browser, so the item with fixed position is positioned relatively to the nearest parent with the transform property (.vue-recycle-scroller__item-view) and not the browser itself.
Here I'm adding a "modal" property the the item object, when set to true, it replace "transform (x or y)" with "left or top" depending on the "direction" also unset the css "will-change" property.
Typical use case : zoom in modal for images or video display