Fix for ESPNow remote causing output glitches #4386
Conversation
Processing of received button command is no longer processed in the callback, instead the value is saved to a variable and processed in the main loop. The actual fix is to not access the file system while data is being sent out: even just trying to open a non-existing file causes glitches on the C3. Waiting for the bus to finish fixes this BUT it causes a frame-delay which is the lesser evil than random color flashes.
|
note: I did not realize I should base for main so this is still 0_15 based. shold I rebase or merge to 0_15 and then cherry pick? |
|
I should be able to just change the base of the PR, no need to cherry-pick |
|
I had lots of conflicts initially when using main as a target, that is why I switched from main to 0_15. |
|
Yeah if you opened before I merged 0_15 into main you would have seen all sorts of issues. At the moment they are basically the same, but if you could please use main for anything new. I'm going through cleaning up anything that is still 0_15 and will make sure all changes to 0_15 have been merged before I finally delete 0_15 |
|
if there are no objections to the updated function names @softhack007 @netmindz this is ready to merge. tested and working. |
|
@DedeHai I possibly have time tomorrow to take a look at your changes. In case I can't review until Saturday, please feel free to merge. Tho overall idea looks sound to me. |
|
this is not urgent, no worries. the outcome is the same, code structure is different. as mentioned in that commit, I'd rather keep the code for the remote contained in remote.cpp as much as possible for clarity and maintainability but maybe my approach has flaws I have not considered. |
Processing of received button command is no longer done in the interrup-callback, instead the value is saved to a variable and processed in the main loop.
The actual fix is to not access the file system while data is being sent out: even just trying to open a (non-existing) file causes glitches on the C3. Waiting for the bus to finish updating soves this BUT it can cause a frame-delay. A short delay however is the lesser evil and much less noticeable than random color flashes.