Bugfix/adc analog audio reactive issue #4345 #4355
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…3690 and #3685) some users have reported that releases after 0.14.0 are not working reliably. So we add a few "compat" for 8266 that try to reproduce the buildenv of 0.14.0 as much as possible. * platform and platform_packages from 0.14.0 * not using PIO_FRAMEWORK_ARDUINO_MMU_CACHE16_IRAM48 * due to smaller IRAM, we had to move some functions back from IRAM to normal flash (may cause slowdown)
Bug Fixes for Issue #4345 - Analog Microphone audio source shows ADC analog - quiet after enable (audioreactive usermod)
|
Not 100% sure what you have done wrong with your PR as it contains very old commits as well as your recent commit. I'm not sure if your branch is just out of date or taken as a branch from the wrong source. It might be best if you create a fresh branch and cherry-pick your commit into that. Would you prefer this to be done against MoonModules in the first instance @softhack007 given that's upstream for this usermod? |
|
The instructions for PRs said to use branch 0_15 ... I see that there are also branches main and 0_15_0 . Is 0_15 the correct branch to use? I can pull a fresh copy. I can also get a copy of MoonModules. Is there a particular branch to use? |
|
Closing this pull request ... will update later. |
|
From MoonModules, please branch mdev |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug Fixes for Issue #4345 - Analog Microphone audio source shows ADC analog - quiet after enable (audioreactive usermod)