Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a setting to create custom quick color buttons #4291

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

colebot17
Copy link

This feature allows custom quick colors to be added from the User Interface settings page.

A string setting holds comma-separated hex values in local storage. When the UI is updated, each color is added as a button underneath the existing colors. With lots of colors, the number of colors per row matches the existing alternating row pattern.

Testing:

  • Invalid hex codes are not added as buttons
  • Extra spaces around the commas have no effect

Limitations:

  • The user must edit the string to change the colors
  • There is no color picker UI available

@DedeHai
Copy link
Collaborator

DedeHai commented Nov 18, 2024

Thank you for the contribution, this is a nice feature, however I do not see it fit for merging as a standard feature:

  • colors are stored locally, meaning only available on the device you created them, correct?
  • not using the color picker is not user friendly

@colebot17
Copy link
Author

I went ahead and updated this to fix the issues.

  • Colors are now defined on the led settings page, and they can be added and removed much like led buses and color order mappings. They take the form of color inputs, leveraging the default browser color picker.
  • Custom colors are now stored in cfg.json, making them common across browsers

@netmindz netmindz changed the base branch from 0_15 to main December 16, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants