-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Translation capability for branch 0_15 #4274
base: main
Are you sure you want to change the base?
Conversation
@Sojourneer please clean up you PR - it seems there are lots of copied files and "cached whatever" that look like backups or intermediate files. I'll mark your PR as draft for the time being. |
@@ -0,0 +1,2 @@ | |||
cd wled00 | |||
sudo python3 UISimulator/main.py "$@" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sudo
should not be needed in a public repository.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know what that means. For example, is it permissible in documentation in a public repository?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it means that i don't want to have scripts that use sudo
. If possible, change to python3 UISimulator/main.py "$@"
.
Running programs with root permissions is only permissible when there is a very good justification.
Where is this document? |
There are no files that are purely generated from something else. |
|
Sorry, I missed your message. I decided a few weeks back to move all the work to a new repository https://github.com/Sojourneer/WLED-Translators-Pack, so all the ugly stuff is elsewhere and it is largely independent of the main repository. The Translator's Pack also includes a proxy server instead of the UI Simulator, in order to get better coverage of the application. The proxy server stuff is new to me and has me tearing my hair out, so the translation stuff has been bumped by other Christmas projects. (Although I have been using it personally). I will get back to this after New Years. |
Translation capability for WLED. Google translated language files provided for JA, FR, DE. Has been tested on an ESP8266.
The coverage is high but not perfect; manual addition of text is required. A more robust solution using a screen scraper on a running WLED instance is probably a better way to go.
From the introduction to the I18N/tools (see wled00/I18N/tools/I18N.md for the details):
WLED Localization
Localization for WLED provides the ability to switch between display languages dynamically from the UI settings page. This setting is local to the browser, and is effective immediately (no Save or page refresh is required).
The rest of this document explains the process for providing this capability.
In summary, the UISimulator Web Server and a couple of python scripts are used to extract, translate, and test the translations on a static simulation of WLED. The translation files are then committed to Github, from which the L12N script included on each HTML page will access and apply the translation.