Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#[derive(Display) for NmeaSentence #64

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

elpiel
Copy link
Member

@elpiel elpiel commented Nov 1, 2022

No description provided.

@codecov
Copy link

codecov bot commented Nov 1, 2022

Codecov Report

Base: 78.54% // Head: 79.22% // Increases project coverage by +0.67% 🎉

Coverage data is based on head (cea36dd) compared to base (d5f1209).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #64      +/-   ##
==========================================
+ Coverage   78.54%   79.22%   +0.67%     
==========================================
  Files          21       22       +1     
  Lines         797      823      +26     
==========================================
+ Hits          626      652      +26     
  Misses        171      171              
Impacted Files Coverage Δ
src/parse.rs 80.39% <ø> (ø)
src/sentences/mod.rs 0.00% <0.00%> (ø)
src/sentences/aam.rs 100.00% <0.00%> (ø)
src/parser.rs 79.36% <0.00%> (+0.08%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@@ -30,6 +31,8 @@ use crate::{sentences::*, Error, SentenceType};
pub const SENTENCE_MAX_LEN: usize = 102;

/// A known and parsable Nmea sentence type.
#[derive(Display)]
#[display("${talker_id},{message_id},{data}*{checksum}")]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The prefix for the sentence start is different for AIS messages!

  • Support multiple prefixes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant