Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for float literals #348

Merged
merged 3 commits into from
Sep 11, 2024
Merged

Add support for float literals #348

merged 3 commits into from
Sep 11, 2024

Conversation

R1kM
Copy link
Member

@R1kM R1kM commented Sep 5, 2024

Companion PR to hacspec/hax#880

Propagates support for float literals such as 1.52f32 or simply 2.0

sonmarcho
sonmarcho approved these changes Sep 5, 2024
View reviewed changes
Copy link
Member

@sonmarcho sonmarcho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, thanks!

Nadrieril
Nadrieril reviewed Sep 5, 2024
View reviewed changes
charon/src/lib.rs Outdated Show resolved Hide resolved
Nadrieril
Nadrieril reviewed Sep 5, 2024
View reviewed changes
charon/src/ast/values.rs Outdated Show resolved Hide resolved
@Nadrieril
Copy link
Member

Since you modified the json output, please increment the version in Cargo.toml and re-run make test

@Nadrieril
Copy link
Member

Could you add FloatValue to the lists of types in generate-ml/main.rs? You'll have to add it twice: once to generate the type definition, and once to generate the json translation. In both cases you can likely add it just below "Literal". And don't forget to increment the version in Cargo.toml

Nadrieril
Nadrieril approved these changes Sep 6, 2024
View reviewed changes
Copy link
Member

@Nadrieril Nadrieril left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, could you please squash (e.g. git reset --soft main; git commit)?

@R1kM R1kM mentioned this pull request Sep 6, 2024
Merged
@R1kM R1kM enabled auto-merge September 11, 2024 13:46
@R1kM R1kM merged commit 35736f4 into main Sep 11, 2024
11 checks passed
@R1kM R1kM deleted the afromher_floats branch September 11, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sonmarcho sonmarcho sonmarcho approved these changes

@Nadrieril Nadrieril Nadrieril approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@R1kM @Nadrieril @sonmarcho