This repository has been archived by the owner on Sep 22, 2022. It is now read-only.
update docker actions and add arm64 image #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @Adven27, wanted to bump this PR to see if you had a chance to review it We've been successfully using grpc-wiremock (thank you for your work on this), but some of us are starting to use M1 machines and find the x86 emulation to be brutally inefficient. The image that this PR produces seems to solve the issue 😄 |
neiljohari
suggested changes
Jul 8, 2022
| context: . | ||
| platforms: linux/amd64,linux/arm64 | ||
| push: ${{ github.event_name != 'release' }} |
There was a problem hiding this comment.
Hm should this be:
Suggested change
| push: ${{ github.event_name != 'release' }} | |
| push: ${{ github.event_name == 'release' }} |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I used the intermediate commits to test this on my local branch. I didn't rebase them out to "show my work" in the PR, but I'm happy to rebase them out if you like.
Here's the action run from my fork:
https://github.com/jstewmon/grpc-wiremock/actions/runs/2235639897
Here's the resulting docker image tag on Docker Hub:
https://hub.docker.com/layers/grpc-wiremock/jstewmon/grpc-wiremock/arm64/images/sha256-41202879efb285cce147179157f5bf1bc87da3f88b371f2c5bbe3f4772ccb965?context=explore
In addition to producing both amd64 and arm64 images, I added a
major.minorimage tag.closes #34