Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support up to Wagtail 5.2 #286

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

leewesleyv
Copy link

@leewesleyv leewesleyv commented Jan 9, 2024

Resolves #285

@leewesleyv leewesleyv changed the title Adds Python3.12 and Wagtail 5.0, 5.1 and 5.2 to Tox and remove support for Wagtail <4.1 Adds support up to Wagtail 5.2 Jan 9, 2024
@leewesleyv leewesleyv marked this pull request as draft January 9, 2024 13:43
@leewesleyv leewesleyv marked this pull request as ready for review January 9, 2024 14:15
@itbabu
Copy link

itbabu commented Jan 21, 2024

@leewesleyv
Hi! Wagtail 5.2 supports Django 4.2.x and 5.0.x.
Is there a reason for 'Django>=3.2,<4.3' requirement?

@leewesleyv
Copy link
Author

leewesleyv commented Jan 22, 2024

@itbabu I was thinking of removing the Django dependency in its entirety, but wasn't sure if that would be the best way forward. The main aim here was to support both Wagtail LTS (5.2) and Django LTS (4.2), where Django was already supported. Hence why I only bumped Wagtail. I'd love to hear what you would recommend in terms of supported versions.

@itbabu
Copy link

itbabu commented Jan 27, 2024

@leewesleyv

Looking into the Wagtail Release schedule (https://github.com/wagtail/wagtail/wiki/Release-schedule), I see that:

Wagtail 5.2 LTS is supported until 3 February 2025.
Wagtail 5.1 is supported until 1 February 2024.
Therefore, it makes sense to support only Wagtail 5.2 and above.

Inspecting the Wagtail setup (https://github.com/wagtail/wagtail/blob/main/setup.py), I found that it requires:

install_requires = [
    "Django>=4.2,<6.0",
    ...
]

Puput should support this range or a subset of it. Django 3.2 falls outside of this range, so it shouldn't be supported.

Consequently, I would remove the Django requirement from Puput setup and keep only the Wagtail requirement.
The testing configurations would be:

@itbabu
Copy link

itbabu commented Jan 30, 2024

@leewesleyv
You can add the changes from this fork to this PR:
https://github.com/itbabu/puput/tree/feature/wagtail-52-support.

Additionally, the other requirements should be addressed:
django-el-pagination: Starting from version 4.1.0, they added support for Django 5.0 and Python 3.12 (not yet on Pypi).
django-taggit and wagtail-markdown: These should be compatible and work as expected.
django-social-share and django-colorful I would remove these packages entirely from the project, as they are outdated.

What are your thoughts?

@leewesleyv
Copy link
Author

@itbabu Especially to what extend django-social-share and django-colorful are used, I think it would be a good decision to remove these dependencies. I will see if I can find a fitting replacement (code-wise) for where we use these, or have a clear migration path for people that are using these functionalities.

@kfields
Copy link

kfields commented Mar 8, 2024

Merge please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

wagtail 5.1 compatibility
3 participants