Add conn_limit to users.yml, #266
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Since this is not a privilege but more of atribute of the user it's better fitted in the users.yml rather then users_privileges.yml . 2. Unfortunately to keep the legacy versions working we need to duplicate task: Make sure the PostgreSQL users are present with some conditionals.
MichalTaratuta
force-pushed
the
add_conn_limit_to_users.yml
branch
from
444a35a
to
84a043e
Compare
|
Am I right the the test are failing due to problem with test not the actual commite code? |
gclough
reviewed
Apr 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since this is not a privilege but more of atribute of the user it's
better fitted in the users.yml rather then users_privileges.yml