Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Peer rate-limiting #756

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

[WIP] Peer rate-limiting #756

wants to merge 7 commits into from

Conversation

pm47
Copy link
Member

@pm47 pm47 commented Nov 15, 2018

No description provided.

@n1bor
Copy link
Contributor

n1bor commented Jan 1, 2019

Any plans to merge this? Just be really good to get the metrics bit merged as was wanting to add a lot more.
So understand what is actually going on in the node and what it is spending time doing.

@pm47
Copy link
Member Author

pm47 commented Jan 2, 2019

This branch is currently running on our production node: the goal is to gather information on the current state of the network and find out the best way to implement peer rate limiting, but the actual work hasn't started yet.

@n1bor
Copy link
Contributor

n1bor commented Jan 2, 2019

Was just wanting to have the codehale metrics commit merged - rather than the rate limiting bit.
Then I can add a number of PR's for:
Timing round some of the db calls.
Rate of events on the EventBus
Cached gauges on number of nodes/channels etc..
Return some of the cached guages in getinfo API call.

Also did you see you can use annotations?
https://metrics.dropwizard.io/4.0.0/apidocs/com/codahale/metrics/annotation/Gauge.html

@pm47 pm47 added WIP and removed WIP labels Apr 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants