-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Handle mutual close in state DATA_WAIT_FOR_FUNDING_CONFIRMED
#723
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…T_FOR_FUNDING_CONFIRMED` state
…utual-close # Conflicts: # eclair-core/src/main/scala/fr/acinq/eclair/channel/Channel.scala # eclair-core/src/main/scala/fr/acinq/eclair/channel/ChannelTypes.scala
c537266 that's your favorite bug @btcontract |
@btcontract I actually got bitten too! see 21c37e4 |
This fixes bug demonstrated in 21c37e4.
There are several more problems with this PR:
|
pm47
changed the title
Handle mutual close in state
[WIP] Handle mutual close in state Sep 27, 2018
DATA_WAIT_FOR_FUNDING_CONFIRMED
DATA_WAIT_FOR_FUNDING_CONFIRMED
This has so many conflicts that it should be re-attempted from scratch, if we ever want to fix it (but it's quite low priority). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a clone of #358 which apparently lost track of the remote branch (
unknown repository
).