-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add payCommitTxFees
flag to LocalParams
#2845
Conversation
3cb219f
to
d3fbd8e
Compare
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #2845 +/- ##
==========================================
+ Coverage 85.96% 86.01% +0.04%
==========================================
Files 219 219
Lines 18441 18441
Branches 762 790 +28
==========================================
+ Hits 15853 15862 +9
+ Misses 2588 2579 -9
|
d3fbd8e
to
f58209a
Compare
The channel initiator traditionnally pays the commit tx fees, but we may want to override that when providing services to wallet users. We thus split the current `isInitiator` flag into two flags: - `isChannelOpener` - `payCommitTxFees` We always set `payCommitTxFees` to the same value as `isChannelOpener`. Custom feature bits may override that behavior if necessary. Note that backwards compatibity is preserved since our previous `bool8` codec encodes `true` as `0xff` and `false` as `0x00`.
f58209a
to
0dfbfd8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IIUC we:
- use
isChannelOpened
:- as
InteractiveTxParams.isInitiator
- in the switch-to-zeroconf logic
- to compute
obscuredCommitTxNumber()
- in the rate limit logic
- as
- use
payCommitTxFees
:- for commitment tx fees
- for closing tx fees
- to decide whether to send
update_fee
That LGTM
eclair-core/src/main/scala/fr/acinq/eclair/channel/ChannelData.scala
Outdated
Show resolved
Hide resolved
And `paysClosingFees`.
It's also worth noting that this PR is perfectly safe to integrate: we introduce the |
The channel initiator traditionnally pays the commit tx fees, but we may want to override that when providing services to wallet users. We thus split the current
isInitiator
flag into two flags:isChannelOpener
payCommitTxFees
We always set
payCommitTxFees
to the same value asisChannelOpener
. Custom feature bits may override that behavior if necessary.Note that backwards compatibity is preserved since our previous
bool8
codec encodestrue
as0xff
andfalse
as0x00
.