Add a warning on linked external events from another scene #6563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
D8H
commented
May 13, 2024
newIDE/app/src/EventsSheet/EventsTree/Renderers/LinkEvent/index.js
Outdated
Show resolved
Hide resolved
4ian
reviewed
May 13, 2024
| {this.isLinkedToWrongLayout(target) ? ( | ||
| <span | ||
| className={classNames({ | ||
| [instructionWarningParameter]: true, |
There was a problem hiding this comment.
Would be surely worth to create a new css class for this - this is not really a parameter and we can see the icon is too small compared to the text.
There was a problem hiding this comment.
I added a CSS rule for an icon in an event link. As the warning class only affect the color and underlining, I guess we could rename instruction-warning-parameter to something like warning-parameter one day.
4ian
reviewed
May 13, 2024
newIDE/app/src/EventsSheet/EventsTree/Renderers/LinkEvent/index.js
Outdated
Show resolved
Hide resolved
4ian
approved these changes
May 14, 2024
|
I suggest we move this to a ℹ️ icon with "Ensure the scene has the same objects, behavior and variables as the one used in these events" as the copy. |
4ian
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes