Show invalid links in red.

4ian · May 14, 2024 · 7308722 · 7308722
1 parent 54bc2b1
commit 7308722
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 1 deletion.
diff --git a/newIDE/app/src/EventsSheet/EventsTree/Renderers/LinkEvent/index.js b/newIDE/app/src/EventsSheet/EventsTree/Renderers/LinkEvent/index.js
@@ -15,6 +15,7 @@ import {
  disabledText,
  icon,
  instructionWarningParameter,
+ instructionInvalidParameter,
 } from '../../ClassNames';
 import InlinePopover from '../../../InlinePopover';
 import ExternalEventsAutoComplete from './ExternalEventsAutoComplete';
@@ -141,6 +142,15 @@ export default class LinkEvent extends React.Component<EventRendererProps, *> {
  );
  };
 
+ isInvalidLink = (target: string): boolean => {
+ const { project } = this.props.scope;
+ return (
+ target.length > 0 &&
+ !project.hasExternalEventsNamed(target) &&
+ !project.hasLayoutNamed(target)
+ );
+ };
+
  render() {
  const linkEvent = gd.asLinkEvent(this.props.event);
  const target = linkEvent.getTarget();
@@ -178,7 +188,15 @@ export default class LinkEvent extends React.Component<EventRendererProps, *> {
  }}
  tabIndex={0}
  >
- {this.isLinkedToWrongLayout(target) ? (
+ {this.isInvalidLink(target) ? (
+ <span
+ className={classNames({
+ [instructionInvalidParameter]: true,
+ })}
+ >
+ {target}
+ </span>
+ ) : this.isLinkedToWrongLayout(target) ? (
  <span
  className={classNames({
  [instructionWarningParameter]: true,

diff --git a/newIDE/app/src/UI/Theme/Global/EventsSheet.css b/newIDE/app/src/UI/Theme/Global/EventsSheet.css
@@ -246,6 +246,10 @@
  color: var(--event-sheet-instruction-parameter-warning-color);
  text-decoration: var(--event-sheet-instruction-parameter-warning-color) underline wavy;
 }
+.gd-events-sheet .link-container .instruction-invalid-parameter {
+ color: var(--event-sheet-instruction-parameter-error-color);
+ text-decoration: var(--event-sheet-instruction-parameter-error-color) underline wavy;
+}
 
 .gd-events-sheet .link-container .selectable {
  color: var(--event-sheet-link-selectable-link-color);